test are failing for something look like not related to this pr

test are failing for something look like not related to this pr

What makes you think that? AFAICT it's definitely related to this PR

my bad

I'm getting the following error when I try your branch:

$ yarn build --force  
packages/crypto/tsconfig.json:4:35 - error TS5096: Option 'allowImportingTsExtensions' can only be used when either 'noEmit' or 'emitDeclarationOnly' is set.

4     "allowImportingTsExtensions": true,
                                    ~~~~


Found 1 error.

BTW I wonder if a better approach would be to split it into several PRs:

1. Switch the custom loader to use the built-in type stripping instead of sucrase.
2. Remove custom test file?
3. Update the specifiers in the source files.
4. Remove the loader eventually.

BTW I wonder if a better approach would be to split it into several PRs:

1. Switch the custom loader to use the built-in type stripping instead of sucrase.
2. Update the specifiers in the source files.
3. Remove the loader eventually.

1. Maybe we should put the build in the CI.
2. I'm not in favor of multiple PRs because the work isn't huge and 80% is already done. All that's left is to fix the build.

I'm not in favor of multiple PRs because the work isn't huge and 80% is already done. All that's left is to fix the build.

How much of the job is done is kinda irrelevant, it should be split nonetheless IMO

I've opened #68 to cover the first step